[8u] TLSv1.3 RFR: 8245653: Remove 8u TLS tests

[Alexey Bakhtin]

Hello Martin,

Thank you for review.
Please find my comments below.

> On 30 Jul 2020, at 00:12, Martin Balao <mbalao at redhat.com> wrote:
> 
> On 5/24/20 2:21 PM, Alexey Bakhtin wrote:
>> Please review changes required to backport TLSv1.3 protocol from JDK11.0.7 to JDK8u
> 
> Hi Alexey,
> 
> Thanks for proposing a patch for Step 10 - 8245653. A few comments below.
> 
> Files that we might want to delete because they were modified in JDK-11
> (11.0.7):
Yes, you are right.
Some of the test below should be also removed in this step . These test passed with both TLSv1.2 and TLSv1.3 implementations but was updated for TLSv1.3.
Please see detailed comments for every test below:
> 
> * test/sun/security/ssl
>  * CertPathRestrictions
>   * JSSEServer.java
>   * TLSRestrictions.java
Yes, these tests are changed, so should be removed in this step
>  * ClientHandshaker
>   * RSAExport.java
Copyright date changed only, no reason to remove/update
>  * DHKeyExchange
>   * LegacyDHEKeyExchange.java
Fixed misprint, but ok remove/update
>  * GenSSLConfigs
>   * main.java
Yes, removed
>  * HandshakeHash
>   * MyProvider.java
Test updated for new Provider API, no reason to update for JDK11
>  * HandshakeOutStream
>   * NullCerts.java
Changes in the comment only. No reason to remove/update
>  * InputRecord
>   * ClientHelloRead.java
Changes not required for JDK8 (@modules annotation)
>   * SSLSocketTimeoutNulls.java
Yes, this test should be removed/updated.
>  * ProtocolVersion
>   * HttpsProtocols.java
Copyright updated without test changes - no reason to remove/update
>  * SSLContextImpl
>   * CustomizedCipherSuites.java
No changes in the test - no reason to remove/update
>  * SSLEngineImpl
>   * DelegatedTaskWrongException.java
Copyright updated without test changes - no reason to remove/update
>  * SSLSocketImpl
>   * CheckMethods.java
>   * NonAutoClose.java
>   * SSLSocketImplThrowsWrongExceptions.java
Yes, these test should be updated. Removed in this step
>   * SetClientMode.java
This test marked @ignore in JDK11 but passed in JDK8 with new TLSv1.3 impleentation. No reason to remove
>  * ServerHandshaker
>   * AnonCipherWithWantClientAuth.java
Yes, this test should be updated. Removed in this step
>   * GetPeerHostClient.java
No functional changes in the test (removed unused import). I think no reason to remove/udate it
>   * GetPeerHostServer.java
No changes in the test
>  * SocketCreation
>   * SocketCreation.java
Yes, this test should be updated. Removed in this step
>  * X509TrustManagerImpl
>   * Symantec
>    * Distrust.java
Yes, this test should be updated. Removed in this step
>   * CheckNullEntity.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
>  * rsa
>   * SignatureOffsets.java
>   * SignedObjectChain.java
Changes not required for JDK8.No reason to remove/update
> * test/com/sun/net/ssl
>  * SSLSecurity
>   * ProviderTest.java
>   * TruncateArray.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
> * test/javax/net/ssl
>  * ALPN
>   * MyX509ExtendedKeyManager.java
>   * SSLServerSocketAlpnTest.java
>   * SSLSocketAlpnTest.java
Changed copyrigth only, no reason to remove tests
>  * SSLParameters
>   * UseCipherSuitesOrder.java
Changed copyrigth only, no reason to remove tests
>  * SSLSession
>   * CheckMyTrustedKeystore.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
>  * ServerName
>   * SSLEngineExplorer.java
>   * SSLSocketExplorer.java
Changed copyrigth only, no reason to remove tests
>  * TLSv11
>   * EmptyCertificateAuthorities.java
>   * GenericBlockCipher.java
>   * GenericStreamCipher.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
>  * TLSv12
>   * ShortRSAKeyGCM.java
>   * SignatureAlgorithms.java
Yes, this test could be updated. Removed in this step
>  * ciphersuites
>   * DisabledAlgorithms.java
No functional changes in the test. No reason to remove/update
>  * etc
>   * keystore
>   * truststore
Yes, these files should be removed in this step.
>  * sanity
>   * pluggability
>    * CheckSSLContextExport.java
No changes required for JDK8 (uses new provider API)
>  * templates
>   * SSLExplorer.java
No functional changes in the test (removed unused import) No reason to remove/update
>  * GetInstance.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
> * test/sun/net/www/protocol/https
>  * HttpsClient
>   * ProxyAuthTest.java
>   * ServerIdentityTest.java
Yes, these tests should be removed in this step.
>  * HttpsURLConnection
>   * B6216082.java
Yes, this test should be removed in this step.
>   * B6226610.java
>   * CheckMethods.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
>   * DNSIdentities.java
No functional changes in the test (removed unused import) No reason to remove/update
>   * HttpsCreateSockTest.java
>   * HttpsSocketFacTest.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
>   * IPAddressDNSIdentities.java
>   * IPAddressIPIdentities.java
>   * IPIdentities.java
>   * Identities.java
No functional changes in the test (removed unused import) No reason to remove/update
>   * PostThruProxy.java
>   * PostThruProxyWithAuth.java
Changes not required for JDK 8. No reason to remove/update
>   * RetryHttps.java
No  functional changes in the test (enabled debug output) No reason to remove/update
>  * NewImpl
>   * ComHTTPSConnection.java
>   * ComHostnameVerified.java
Yes, these tests should be removed in this step.
>  * ChunkedOutputStream.java
Changes not required for JDK8 (@modules annotation). No reason to remove/update
> 
> If there is a reason not to delete them, please let me know.
> 


I have updated patch at :
http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245653/webrev.v1/

Regards
Alexey