[8u] RFR 6424123: JVM crashes on failed 'strdup' call

Andrew Hughes gnu.andrew at redhat.com
Mon Aug 3 17:26:15 UTC 2020


On 09:29 Fri 31 Jul     , Andrew Haley wrote:
> On 7/30/20 4:19 PM, Hohensee, Paul wrote:
> > I took a look at the webrev. Doesn't seem that extensive (or risky) to me.
> > 
> > Summary of changes: 69 lines changed: 40 ins; 0 del; 29 mod; 31448 unchg.
> > 
> > If we don't do it, besides making future backports a bit more difficult, we'll have a (admittedly subtle) behavioral difference with Oracle, which in this case doesn’t seem justified to me.
> 
> Mmm, OK, that's a way of looking at it. I guess that is enough to
> swing behind acceptance of this patch. It's good.
> 
> -- 
> Andrew Haley  (he/him)
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> https://keybase.io/andrewhaley
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
> 

If this is going to now be included, it needs to also fix the cases
where we worked around its absence. Does this proposed patch do so?

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list