[8u] RFR: 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics

Aleksey Shipilev shade at redhat.com
Tue Aug 4 16:21:25 UTC 2020


On 8/4/20 5:49 PM, Severin Gehwolf wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8250627
> webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8250627/jdk8/01/
> JDK 11 change: https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/a75956082916

Substantially, I think the patch is fine.

But, I do wonder if the new classes should be in sun.misc.*, not in jdk.internal.*. One of the
reasons to use sun.misc.* is to get the proper javac warning on use. jdk.internal is something that
is protected by module boundaries in JDK 9+, not available in 8u.

-- 
Thanks,
-Aleksey




More information about the jdk8u-dev mailing list