[8u] RFR: 8191678: [TESTBUG] Add keyword headful in java/awt and javax tests.

[Andrew Hughes]

On 11:53 Mon 06 Jul     , Alex Kashchenko wrote:
> Hi,
> 
> Please review the backport of JDK-8191678 to 8u:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8191678
> 
> Original change: https://hg.openjdk.java.net/jdk/jdk/rev/50d61f4b5d1a
> 
> 8u webrev: https://cr.openjdk.java.net/~akasko/jdk8u/8191678/webrev.00/
> 
> This change adds "headful" keyword to a number of client tests. Only a
> single test (FocusTransitionTest) from this patch is present in 8u - only
> changes to it are backported.
> 
> Testing: checked that changed test can be selected with "headful" keyword.
> 
> -- 
> -Alex
> 

test/jdk/java/awt/Component/GetScreenLocTest/ComponentGetLocationOnScreenNPETest.java:

JDK-8189204: Possible NPE in Component::getLocationOnScreen(), not flagged for backport

test/jdk/java/awt/Dialog/SiblingChildOrder/SiblingChildOrderTest.java:

JDK-8190230: [macosx] Order of overlapping of modal dialogs is wrong, not flagged for backport

jdk/test/javax/swing/DefaultButtonModel/DefaultButtonModelCrashTest.java:

8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel, not flagged for backport

test/jdk/javax/swing/GraphicsConfigNotifier/TestMultiScreenGConfigNotify.java:

8178025: HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other, not flagged for backport

test/jdk/javax/swing/JButton/TestGlyphBreak.java:

8191428: Regression: Swing button label wrapping with hidpi, not flagged for backport

jdk/test/javax/swing/JComboBox/8182031/ComboPopupTest.java:

8182031: Swing's ComboBox Popup opens and closes immediately, not flagged for backport

test/jdk/javax/swing/JMenu/8178430/LabelDotTest.java:

8178430: JMenu in GridBagLayout flickers when label text shows "..." and is updated, not flagged for backport

test/jdk/javax/swing/JTextArea/TestTabSize.java:

8187957: Tab Size does not work correctly in JTextArea, not flagged for backport

jdk/test/javax/swing/dnd/8139050/NativeErrorsInTableDnD.java:

8139050: -[AWTView draggingEnded:]: unrecognized selector message during drag and drop, not flagged for backport

jdk/test/javax/swing/plaf/nimbus/TestNimbusOverride.java:

8043315: Nimbus: Setting Nimbus.Overrides property affects custom keymap installation, not flagged for backport

test/jdk/javax/swing/text/DefaultCaret/HidingSelection/HidingSelectionTest.java:

8188081: Text selection does not clear after focus is lost, not flagged for backport

So all seem safe to exclude. In future, please provide such evidence
for making such exclusions, especially when the vast majority of the
patch is being dropped, as in this case.

We don't want to drop such changes if another backport is about to
introduce that test.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222