[8u] RFR: 8220657: JFR.dump does not work when filename is set

[Andrew Hughes]

On 07:11 Thu 06 Aug     , Ekaterina Vergizova wrote:
> Hi Andrew,
> the method getRealPathText() is introduced by 8224217 which is already approved and included into jdk8u-dev [1].
> So the proposed 8220657 patch build successfully against the latest jdk8u-dev.
> 
> In 11u these patches were applied in reverse order, that's why some additional modifications with getText()/getRealPathText() were required for both of them.
> 
> Thanks, Ekaterina
> 
> [1] https://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/87091b543626
> 

Right, I saw that later when pulling in the most recent changes. I
didn't expect that to be necessary, given the 8220657 patch was posted
before the last build promotion, on 2020-07-30. 8224217 was not pushed
until 2020-08-03. Please don't post patches that rely on changes that
aren't yet committed.

Thanks for the explanation on getRealPathText(). I assume the change
to that line was part of 8224217 in 11u, but couldn't be applied in 8u
because that fix was backported before 8220657. Please try and keep to
the same order where possible.

I'm happy enough with this now and it can be re-flagged for approval
(jdk8u-fix-request).

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222