[8u] RFR: 8203357: Container Metrics

Andrew Hughes gnu.andrew at redhat.com
Fri Aug 7 05:01:49 UTC 2020


On 11:35 Thu 06 Aug     , Severin Gehwolf wrote:

snip...

> > 
> > New webrev:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8203357/jdk8/02/webrev/
> > 
> > Thoughts?
> 
> Ping? This is blocking some other backports in my queue.
> 
> Thanks,
> Severin
> 

This is the first time I've seen this. I was busy with the 8u265
release last week and then away on the Thursday.

To make this manageable, I again split it into the existing changes
and the three new files, LauncherHelper.java, launcher.properties and
Settings.java.

Comparing this patch (sans changes to those files) with the original
shows the author tags being reinstated. Looks fine.

Comparing the three new sets of changes with the 11u changes:

* LauncherHelper.java: Missing copyright header change.
* launcher.properties: Ordering is different in 8u but change seems ok.
* Settings.java: is checkNoContains the same as checkNotContains?
JDK-8154470 seems to suggest so, as well as explaining the indentation
difference as well.

Action items; just the missing copyright header, AFAICS.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list