[8u] RFR: 8203357: Container Metrics
Severin Gehwolf
sgehwolf at redhat.com
Fri Aug 7 12:33:24 UTC 2020
On Fri, 2020-08-07 at 14:05 +0200, Severin Gehwolf wrote:
> > * Settings.java: is checkNoContains the same as checkNotContains?
>
> I believe so, yes.
Well for the purpose of this test it should be fine to use
checkNoContains. It's used elsewhere in Settings.java test too.
checkNotContains doesn't exist.
> JDK 8's checkNoContains is:
> static void checkNoContains(TestResult tr, String str) {
> if (tr.contains(str)) {
> System.out.println(tr.status);
> throw new RuntimeException(str + " found");
> }
> }
>
> JDK 11's checkNotContains is:
> static void checkNotContains(TestResult tr, String str) {
> if (!tr.notContains(str)) {
> System.out.println(tr);
> throw new RuntimeException(str + " found");
> }
> }
Actually, the status message which is being printed if the test fails
will be slightly different in JDK 8. But for the purpose of this test
this shouldn't matter.
Thanks,
Severin
More information about the jdk8u-dev
mailing list