[8u] RFR: 6574989: TEST_BUG: javax/sound/sampled/Clip/bug5070081.java fails sometimes

[Severin Gehwolf]

Hi Jon,

On Tue, 2020-07-14 at 15:50 +0100, Jonathan Dowland wrote:
> Hello,
> 
> Please review this "backport" of JDK-6574989 to 8u, for parity with
> Oracle 8u271.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-6574989
> jdk9 patch: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/0f4994564ae6
> 
> webrev (I needed the practice generating one):
>     https://jmtd.net/tmp/JDK-6574989/ 
> 
> The patch applies cleanly to jdk8u-dev without path changes, and the
> test builds and runs post patching with java(1) built from jdk8u-dev,
> so I suppose label jdk8u-fix-request is sufficient?
> 
> However, on my system (Linux/amd64; the original report description
> states "fails sometimes on windows platforms"), both pre and post patch,
> the test consistently fails. I'm not sure whether that warrants further
> investigation, or whether that should block backporting the patch.

It's the opposite for me. Fails consistently pre patch. Passes after.
Looks good. Approved.

Thanks,
Severin