[8u] RFR 8160768: Add capability to custom resolve host/domain names within the default JNDI LDAP provider

[Zhengyu Gu]

On 8/10/20 9:25 AM, Langer, Christoph wrote:
> Hi Zhengyu,
> 
> as has been pointed out, you'll need to move the two classes from package javax.naming.ldap.spi into package com.sun.jndi.ldap.spi.
Yes. My latest webrev:

http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.02/
http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/langtools/webrev.01/

but LdapDnsProviderTest.java test failed with connection denial, looks 
like there may be security implications.

Thanks,

-Zhengyu

> 
> After all, 8u backport should be easier than 11u backport for this patch since there's no implication with export restrictions from platform modules in JDK8 ��
> 
> Best regards
> Christoph
> 
>> -----Original Message-----
>> From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> On Behalf Of Zhengyu
>> Gu
>> Sent: Mittwoch, 5. August 2020 15:49
>> To: Hohensee, Paul <hohensee at amazon.com>; jdk8u-dev <jdk8u-
>> dev at openjdk.java.net>
>> Cc: 1983-01-06 at gmx.net
>> Subject: Re: [8u] RFR 8160768: Add capability to custom resolve host/domain
>> names within the default JNDI LDAP provider
>>
>> Hi Paul,
>>
>> Sorry for replying late. Somehow, this email slipped through the cracks,
>> and thanks Michael for bringing it to my attention.
>>
>>
>> On 7/13/20 5:27 PM, Hohensee, Paul wrote:
>>> The webrev looks it's corrupted. E.g., it includes the changes from 8217606,
>> and not the InitialDirContext.java and CheckConfigs.policy changes you
>> mention.
>>
>> It had dependence on 8217606, now it is pushed, so that the webrev is
>> much cleaner.
>>
>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.01/
>>
>> Test:
>>     Reran jdk_other.
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
>>
>>>
>>> Paul
>>>
>>> On 7/9/20, 1:39 PM, "jdk8u-dev on behalf of Zhengyu Gu" <jdk8u-dev-
>> retn at openjdk.java.net on behalf of zgu at redhat.com> wrote:
>>>
>>>       Hi,
>>>
>>>       I would like to backport this patch to 8u for parity with Oracle 8u261.
>>>
>>>       The original patch does not apply cleanly.
>>>
>>>       Other than a couple of minor conflicts:
>>>
>>>       1) Comments in InitialDirContext.java did not apply cleanly
>>>       2) Unpatched CheckConfigs.policy files did not match
>>>
>>>       I made following modification for 8u:
>>>
>>>       1) Removed module-info.java section, it does not apply to 8u.
>>>       2) LdapDnsProvider.java and LdapDnsProviderResult.java use APIs
>>>       (List.copyOf() and List.of()) that do not exist in jdk8. Rewrote the
>>>       code with ArrayList<String>.
>>>       3) Removed @modules annotation in LdapDnsProviderTest.java
>>>
>>>       Additional, I need to modify langtools to get javac to take
>>>       com.sun.jndi.ldap.spi package and complain about it.
>>>
>>>       Original bug: https://bugs.openjdk.java.net/browse/JDK-8160768
>>>       Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/a609d549992a
>>>
>>>       8u jdk webrev: http://cr.openjdk.java.net/~zgu/JDK-8160768-
>> 8u/jdk/webrev.00/
>>>       8u langtools webrev:
>>>       http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/langtools/webev.00/
>>>
>>>
>>>       Test:
>>>          jdk_other on Linux x86_64
>>>
>>>       Thanks,
>>>
>>>       -Zhengyu
>>>
>>>
>>>
>