[8u] RFR 8160768: Add capability to custom resolve host/domain names within the default JNDI LDAP provider

[Hohensee, Paul]

I don't think you can have the same CSR for both releases because it messes up the accounting. I.e., there's a backport issues for 8u and another one for 11u, and each of these needs its own CSR. The two CSRs will have identical content in this case. :)

Paul

On 8/10/20, 5:25 AM, "Langer, Christoph" <christoph.langer at sap.com> wrote:

    Hi,

    as I'm in parallel working on an 11u backport and have the same requirement for a CSR, I added release 11-pool to the CSR item (JDK-8251270). I think we can have one CSR for both releases. The user-visible change that we want to do, that is, the introduction of com.sun.jndi.ldap.spi. LdapDnsProvider and com.sun.jndi.ldap.spi. LdapDnsProviderResult is the same, so I guess it is most convenient.

    Hope you're all ok with that? (I'll take no answer as a yes ��)

    I'll also go ahead and rephrase the CSR to use com.sun.jndi.ldap.spi instead of javax.naming.ldap.spi.

    Best regards
    Christoph

    > -----Original Message-----
    > From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> On Behalf Of
    > Hohensee, Paul
    > Sent: Freitag, 7. August 2020 18:15
    > To: Zhengyu Gu <zgu at redhat.com>; Severin Gehwolf
    > <sgehwolf at redhat.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>;
    > Andrew Hughes <gnu.andrew at redhat.com>
    > Subject: RE: [8u] RFR 8160768: Add capability to custom resolve host/domain
    > names within the default JNDI LDAP provider
    >
    > We do, because any behavioral/API change needs one, even to platform
    > dependent classes.
    >
    > On 8/7/20, 7:44 AM, "Zhengyu Gu" <zgu at redhat.com> wrote:
    >
    >     On 8/7/20 9:55 AM, Hohensee, Paul wrote:
    >     > You can backport this to 8u. As Michael Osipov wrote (and Alan as a
    > comment on the 8u CSR), you just need to change the 8u CSR and patch to
    > move the new functionality to com.sun.jndi.ldap  and com.sun.jndi.ldap.spi.
    >
    >     Right. But we don't need CSR for that, correct?
    >
    >     Thanks,
    >
    >     -Zhengyu
    >
    >     >
    >     > Thanks,
    >     > Paul
    >     >
    >     > On 8/7/20, 5:48 AM, "Zhengyu Gu" <zgu at redhat.com> wrote:
    >     >
    >     >      CAUTION: This email originated from outside of the organization. Do
    > not click links or open attachments unless you can confirm the sender and
    > know the content is safe.
    >     >
    >     >
    >     >
    >     >      Hi Paul,
    >     >
    >     >      Based on Alan Bateman's comment, we can not backport public API to
    > 8u. I
    >     >      guess LdapDnsProvider.java and LdapDnsProviderResult.java have to
    > be
    >     >      moved to com.sun.jndi.ldap and com.sun.jndi.ldap.spi packages.
    >     >
    >     >      I will withdraw this CSR, ok?
    >     >
    >     >      Thanks,
    >     >
    >     >      -Zhengyu
    >     >
    >     >
    >     >
    >     >
    >     >
    >     >      On 8/6/20 5:32 PM, Hohensee, Paul wrote:
    >     >      > I filed a backport issue
    >     >      >
    >     >      > https://bugs.openjdk.java.net/browse/JDK-8251270
    >     >      >
    >     >      > and corresponding CSR
    >     >      >
    >     >      > https://bugs.openjdk.java.net/browse/JDK-8251270
    >     >      >
    >     >      > and assigned them to Zhengyu.
    >     >      >
    >     >      > On 8/6/20, 1:50 PM, "jdk8u-dev on behalf of Hohensee, Paul"
    > <jdk8u-dev-retn at openjdk.java.net on behalf of hohensee at amazon.com>
    > wrote:
    >     >      >
    >     >      >      +1 on needing a CSR for the backport. I'd missed the CSR link
    > because it was buried under "Show 5 more links".
    >     >      >
    >     >      >      I posted an RFO (Request for Opinion) on the same topic of
    > approving strictly additive CSRs for backport.
    >     >      >
    >     >      >      https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-
    > August/012319.html
    >     >      >
    >     >      >      Thanks,
    >     >      >      Paul
    >     >      >
    >     >      >      On 8/6/20, 8:02 AM, "jdk8u-dev on behalf of Severin Gehwolf"
    > <jdk8u-dev-retn at openjdk.java.net on behalf of sgehwolf at redhat.com>
    > wrote:
    >     >      >
    >     >      >          On Thu, 2020-08-06 at 10:13 -0400, Zhengyu Gu wrote:
    >     >      >          > > The original patch required a CSR[1], so we should file one
    > for JDK 8u
    >     >      >          > > too. I wonder where the CSR is for Oracle JDK 8, though.
    >     >      >          >
    >     >      >          > It does not seem to have a CSR for 11u backport(?) Do 8u need
    > one?
    >     >      >
    >     >      >          Right. I don't know about what happened there for Oracle JDK.
    > You could
    >     >      >          try to ask.
    >     >      >
    >     >      >          I believe we need one since this is changing the 8 SE API by
    > adding:
    >     >      >
    >     >      >          javax/naming/ldap/spi/LdapDnsProvider.java
    >     >      >          javax/naming/ldap/spi/LdapDnsProviderResult.java
    >     >      >
    >     >      >          Thanks,
    >     >      >          Severin
    >     >      >
    >     >      >
    >     >      >
    >     >
    >     >
    >