[8u] RFR: 8250875: Incorrect parameter type for update_number in JDK_Version::jdk_update

Hohensee, Paul hohensee at amazon.com
Mon Aug 10 15:52:29 UTC 2020


Lgtm. I updated the issue description to explain why this is needed.

Thanks,
Paul

On 8/8/20, 1:54 AM, "jdk8u-dev on behalf of Denghui Dong" <jdk8u-dev-retn at openjdk.java.net on behalf of denghui.ddh at alibaba-inc.com> wrote:

    A gentle ping.

    Thanks.



    ------------------------------------------------------------------
    From:董登辉(卓昂) <denghui.ddh at alibaba-inc.com>
    Send Time:2020年7月31日(星期五) 16:00
    To:jdk8u-dev <jdk8u-dev at openjdk.java.net>
    Subject:[8u] RFR: 8250875: Incorrect parameter type for update_number in JDK_Version::jdk_update

    Hi,
    Could I have a review of this trivial fix that amend the type of update_number in JDK_Version::jdk_update?
    Summary:
    Now the update number is over 255, and if we make some flags obsolete later,
    it will cause a build failure

    Bug: https://bugs.openjdk.java.net/browse/JDK-8250875
    Webrev: http://cr.openjdk.java.net/~ddong/8250875/webrev.00/

    Thanks
    Denghui Dong



More information about the jdk8u-dev mailing list