[8u] TLSv1.3 RFR: 8245681: Add TLSv1.3 regression test from 11.0.7

Alexey Bakhtin alexey at azul.com
Wed Aug 12 17:51:05 UTC 2020


Hello Martin,

Please find new version of the patch for TLSv1.3 regression tests:
http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245681/webrev.v2/
Git diff: http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245681/webrev.v2/jdk.git.diff

This patch adds TLS related tests from JDK11.07 without any modification.
This patch does not include:
- DTLS tests:
  - javax/net/ssl/DTLS
  - javax/net/ssl/DTLSv10
  - sun/security/ssl/SSLContextImpl
    - CustomizedDTLSDefaultProtocols.java
    - CustomizedDTLSServerDefaultProtocols.java
    - DefaultDTLSEnabledProtocols.java
- javax/net/ssl/finalize:
   This test was added as part of JDK-8169416. Not related to TLSv1.3 implementation. Test uses unsupported Reference.reachabilityFence
- javax/net/ssl/HttpsURLConnection/Equals.java
   This test was added as part of JDK-8055299. Not backported to JDK8 yet
- MFLNTest tests:
  - javax/net/ssl/TLS/TLSMFLNTest.java
  - javax/net/ssl/TLS1/TLSMFLNTest.java
  - javax/net/ssl/TLS11/TLSMFLNTest.java
  These tests based on the SSLParameters.setMaximumPacketSize​() public API which is not  available in JDK8:
- TEST.properties files for different tests. These files are not required for JDK8

Regards
Alexey


> On 22 Jul 2020, at 21:44, Alexey Bakhtin <alexey at azul.com> wrote:
> 
> Please find updated patch for TLSv1,3 regression tests:
> http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245681/webrev.v1
> 
> This version fixes test issues caused by client default disabled TLSv1.3 protocol :
> - javax/net/ssl/SSLSession/ResumeTLS13withSNI.java
> - javax/net/ssl/SSLSocket/Tls13PacketSize.java
> - javax/net/ssl/Stapling/HttpsUrlConnClient.java
> - javax/net/ssl/Stapling/SSLEngineWithStapling.java
> - javax/net/ssl/Stapling/SSLSocketWithStapling.java
> - javax/net/ssl/Stapling/StapleEnableProps.java
> - javax/net/ssl/sanity/ciphersuites/CheckCipherSuites.java
> 
> Also, this version reverts incorrectly modified  sun/security/krb5/auto/SSL.java test
> 
> Regards
> Alexey
> 
>> On 28 May 2020, at 19:56, Alexey Bakhtin <alexey at azul.com> wrote:
>> 
>> Hello Dmitry,
>> 
>> Yes, you are right.
>> I’ve uploaded non-incremental webrev for the JDK-8245653 "Remove 8u TLS tests” by mistake.
>> I’ve updated it in the same location : http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245653/webrev.v0/
>> 
>> JDK-8245681 should be applied cleanly now
>> 
>> Thank you
>> Alexey
>> 
>> 
>>> On 28 May 2020, at 19:07, Dmitry Cherepanov <dcherepanov at azul.com> wrote:
>>> 
>>> Hi Alexey,
>>> 
>>> On 24.05.2020 21:05, Alexey Bakhtin wrote:
>>>> Please review changes required to backport TLSv1.3 protocol from JDK11.0.7 to JDK8u
>>>> 
>>>> JBS task: https://bugs.openjdk.java.net/browse/JDK-8245681
>>>> Webrev: http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245681/webrev.v0/
>>>> 
>>>> This is a third part of TLS test update.
>>> 
>>> When I tried to apply patches, I got conflicts in the last step. There are a lot of rejects due to the fact that new test files already exist.
>>> 
>>> For example, the third part (of test update) adds new file - test/javax/net/ssl/ALPN/SSLEngineAlpnTest.java
>>> which existed before and was moved by the first part (of test update)  from test/sun/security/ssl/javax/net/ssl/ALPN/SSLEngineAlpnTest.java to test/javax/net/ssl/ALPN/SSLEngineAlpnTest.java
>>> 
>>> Could you please double check that it's the latest version of webrev?
>>> 
>>> Thanks
>>> 
>>> Dmitry
>>> 
> 



More information about the jdk8u-dev mailing list