[8u] RFR 8160768: Add capability to custom resolve host/domain names within the default JNDI LDAP provider

Zhengyu Gu zgu at redhat.com
Thu Aug 13 12:49:57 UTC 2020



On 8/13/20 5:51 AM, Severin Gehwolf wrote:
> On Tue, 2020-08-11 at 14:48 -0400, Zhengyu Gu wrote:
>> Hi Michael,
>>
>>> My tests/comments:
>>> * @since still says 12. Is that correct?
> 
> I agree. Zhengyu, please remove the @since 12 tags in this backport. It
> doesn't make sense to have them in either 11 or 8.

Okay, updated:

http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.03/

Could I get formal review? Michael reviewed/tested previous version, but 
I don't see him on 8u reviewer list.

Also, I see a new CR (JDK-8251269) for this backport, I assume I should 
use JDK-8251269 to push this backport, correct?

Thanks,

-Zhengyu


> 
>>> * Should LdapDnsProvider and LdapDnsProviderResult document that they
>>> have been moved in 12?
>>
>> Right. I am not sure about that. Paul and Christoph, anything suggestions?
> 
> I don't think this should be documented in JDK head (which would be JDK
> 16 now). After all, JDK 11 and JDK 8 fixes are *backports* of the
> original fix in JDK 12. I'm afraid, this is something for users to know
> and adjust accordingly for later JDK migrations.
> 
> Thanks,
> Severin
> 



More information about the jdk8u-dev mailing list