[8u] RFR: 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics

Severin Gehwolf sgehwolf at redhat.com
Thu Aug 13 12:55:02 UTC 2020


Hi Aleksey,

On Tue, 2020-08-04 at 18:21 +0200, Aleksey Shipilev wrote:
> On 8/4/20 5:49 PM, Severin Gehwolf wrote:
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8250627
> > webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8250627/jdk8/01/
> > JDK 11 change: https://hg.openjdk.java.net/jdk-updates/jdk11u-dev/rev/a75956082916
> 
> Substantially, I think the patch is fine.

Can I consider this patch reviewed?

> But, I do wonder if the new classes should be in sun.misc.*, not in jdk.internal.*. One of the
> reasons to use sun.misc.* is to get the proper javac warning on use. jdk.internal is something that
> is protected by module boundaries in JDK 9+, not available in 8u.

With JDK-8203357 now in 8u, I wonder whether we should amend javac to
print warnings for jdk.internal packages too? Would that help alleviate
your concern?

Thanks,
Severin



More information about the jdk8u-dev mailing list