[RFR] [8u] 8078334: Mark regression tests using randomness

[Andrew Haley]

On 20/08/2020 19:19, Andrew Hughes wrote:
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8078334/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8078334
> 
> This is a long but simple patch, which tags a number of test cases. It
> removes unnecessary differences between the copies of these test cases
> in 8u and in later versions, simplifying future backports (in
> particular, those for PKCS#11).
> 
> Most of the differences between this patch and the 9u version are due
> to differing context and a few missing test cases:
> 
> * The TEST.ROOT change is already present in 8u, thanks to
> JDK-8151731: "Add new jtreg keywords to jdk 8"
> 
> * The test/com/oracle/security ucrypto tests are not present in 8u, as
> UCrypto wasn't added to OpenJDK until JDK-8046002: "Move Ucrypto to
> the open jdk repo". It's a Solaris feature so I see little need to
> backport it.
> 
> * test/com/sun/crypto/provider/Cipher/RSA/TestOAEP.java has an
> additional bug ID in 8u, changing the context.
> 
> * test/java/io/InputStream/TransferTo.java is not present in 8u, as
> the transferTo method is not in 8u (introduced by JDK-8066867: Add
> InputStream transferTo to transfer content to an OutputStream)
> 
> * test/java/lang/ClassLoader/Assert.java, test/java/lang/Math/HypotTests.java,
> test/java/lang/Math/IeeeRecommendedTests.java, test/java/lang/Math/Log1pTests.java
> have slight context differences in 8u.
> 
> * test/java/lang/invoke/MethodHandles/CatchExceptionTest.java does not
> have the "intermittent" keyword in 8u. It seems JDK-8055269:
> "java/lang/invoke/MethodHandles/CatchExceptionTest.java fails
> intermittently" will have fixed this.
> 
> * test/java/math/BigDecimal/StringConstructor.java,
>   test/java/math/BigInteger/BigIntegerTest.java,
>   test/java/math/BigInteger/ModPow65537.java,
>   test/java/math/BigInteger/PrimeTest.java,
>   test/java/math/BigInteger/SymmetricRangeTests.java,
>   test/java/util/Arrays/Correct.java,
>   test/java/util/Base64/TestBase64.java,
>   test/java/util/BitSet/BSMethods.java have slight
>   context differences in 8u (fewer bug IDs)
> 
> * test/java/util/logging/FileHandlerLongLimit.java was introduced by
> JDK-8059767: "FileHandler should allow 'long' limits and handle
> overflow of MeteredStream.written.", which is an enhancement out of
> scope for backport.
> 
> * test/java/util/logging/FileHandlerPatternExceptions.java was
>   introduced by JDK-8025690: "Default FileHandler constructor doesn't
>   throw NullPointerException if pattern is empty and count > 1" which
>   changes the behaviour of a public constructor and so too risky for
>   backport.
> 
> * test/java/util/logging/LogManager/Configuration/ParentLoggerWithHandlerGC.java
>   was introduced by JDK-8060132: "Handlers configured on abstract
>   nodes in logging.properties are not always properly closed", which
>   changes behaviour in a way worthy of a release note, so not suitable
>   for backport.
> 
> * test/java/util/logging/LoggingDeadlock.java has slight context differences.
> 
> * test/java/util/zip/DeInflate.java already gained the tag in
> JDK-8184682: "Upgrade compression library"
> 
> * test/java/util/zip/InflateIn_DeflateOut.java,
>   test/sun/nio/cs/TestStringCoding.java,
>   test/java/util/zip/ZipFile/ReadZip.java have additional bug IDs in
>   8u.
> 
> * test/java/util/zip/ZipFile/Assortment.java,
>   test/java/util/zip/ZipFile/MultiThreadedReadTest.java,
>   test/javax/crypto/KeyGenerator/TestKGParity.java,
>   test/sun/management/jmxremote/startstop/JMXStartStopTest.java,
>   test/sun/misc/FloatingDecimal/TestFloatingDecimal.java,
>   test/sun/security/provider/DSA/TestDSA2.java,
>   test/sun/security/rsa/TestKeyPairGenerator.java and
>   test/sun/security/rsa/TestSignatures.java have slight context
>   differences.
>   
> * test/sun/security/mscapi/PrngSlow.java has an additional @requires
>   in 8u.
> 
> * test/javax/net/ssl/SSLEngine/LargeBufs.java,
>   test/sun/security/ssl/GenSSLConfigs/main.java and
>   test/sun/security/ssl/ClientHandshaker/LengthCheckTest.java can be
>   found in
>   test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargeBufs.java,
>   test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java
>   and
>   test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/LengthCheckTest.java
>   in 8u, respectively. Backporting JDK-8032473: "Restructure JSSE
>   regression test hierarchy in jdk test" seems pointless, given the
>   imminent import of TLS 1.3.
> 
> Ok for 8u?

Looking at https://cr.openjdk.java.net/~andrew/openjdk8/8078334/webrev.01/, all
I see is

+ * @key randomness

added to many files. That's fine.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671