[RFR] [8u] 8078334: Mark regression tests using randomness

[Andrew Hughes]

On 13:38 Fri 21 Aug     , Martin Balao wrote:
> Hi Andrew,
> 
> Thanks for proposing this backport.
>

You're welcome. Hopefully we can finally get these PKCS#11 fixes
resolved between us today.

> 
> > * test/javax/net/ssl/SSLEngine/LargeBufs.java,
> >   test/sun/security/ssl/GenSSLConfigs/main.java and
> >   test/sun/security/ssl/ClientHandshaker/LengthCheckTest.java can be
> >   found in
> >   test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargeBufs.java,
> >   test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java
> >   and
> >   test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/LengthCheckTest.java
> >   in 8u, respectively. Backporting JDK-8032473: "Restructure JSSE
> >   regression test hierarchy in jdk test" seems pointless, given the
> >   imminent import of TLS 1.3.
> 
> I agree with not relocating the tests because of this backport. Even
> though your decision looks good in the context of this backport, this
> will bring conflicts with the TLS 1.3 work we are doing. The TLS 1.3
> work includes an 8u backport of 8032473.
>

I take it the TLS 1.3 backport will reference 8032473?

> >
> > Ok for 8u?
> >
> 
> May I ask you to undo the changes for LargeBufs.java,
> LengthCheckTest.java and GenSSLConfigs/main.java? Even though they are
> correct for this backport, they will bring future conflicts when
> merging the TLS 1.3 work. My promise is that the TLS 1.3 backport (at
> Step 11) includes the 'randomness' key for all these files. I've just
> verified it.
>

I did wonder about this during the backport. I've reverted those three files:

https://cr.openjdk.java.net/~andrew/openjdk8/8078334/webrev.02/

> Thanks,
> Martin.-
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222