[8u] TLSv1.3 RFR: 8245681: Add TLSv1.3 regression test from 11.0.7

Martin Balao mbalao at redhat.com
Fri Aug 21 19:35:42 UTC 2020


Hi Alexey,

On 8/13/20 6:21 AM, Alexey Bakhtin wrote:
>>
>>> - javax/net/ssl/HttpsURLConnection/Equals.java
>>>   This test was added as part of JDK-8055299. Not backported to JDK8 yet
>>
>> Why?
> JDK-8055299 is not backported to JDK8u and not related to TLSv1.3 functionality.
> This fix can be backported separately

Yes, you're right.

>> In addition to the previous, I've noticed that Step 11 adds a few files
>> not in previous SSL-related categories:
>>
>>  * test/java/security/testlibrary/CertificateBuilder.java (new)
>>  * test/java/security/testlibrary/SimpleOCSPServer.java (new)
> These classes used by javax/net/ssl/Stapling and sun/security/ssl/Stapling tests
> These classes was added as part of JDK-8046321: OCSP Stapling for TLS
>>  * test/lib/testlibrary/jdk/testlibrary/SimpleSSLContext.java (new)
> This class should be excluded.
> It is used by javax/net/ssl/HttpsURLConnection/Equals.java which is not added in this step, so SimpleSSLContext.java is not required
> 
>>
>> How did you find them?
> 
> I've found these classes by running and fixing test dependency

Ah, right! I've listed the test changes introduced by 8046321 (which we
backported to 8u in Step 6 - 8245473):

 * test/java/security/testlibrary/CertificateBuilder.java (new)
 * test/java/security/testlibrary/SimpleOCSPServer.java (new)
 * test/javax/net/ssl/DTLS/NoMacInitialClientHello.java (modified)
 * test/javax/net/ssl/Stapling/HttpsUrlConnClient.java (new)
 * test/javax/net/ssl/Stapling/SSLEngineWithStapling.java (new)
 * test/javax/net/ssl/Stapling/SSLSocketWithStapling.java (new)
 *
test/sun/security/provider/certpath/Extensions/OCSPNonceExtensionTests.java
(new)
 * test/sun/security/provider/certpath/ResponderId/ResponderIdTests.java
(new)
 * test/sun/security/ssl/ExtensionType/OptimalListSize.java (modified)
 * test/sun/security/ssl/StatusStapling/BogusStatusRequest.java (new)
 * test/sun/security/ssl/StatusStapling/CertStatusReqExtensionTests.java
(new)
 * test/sun/security/ssl/StatusStapling/CertStatusReqItemV2Tests.java (new)
 *
test/sun/security/ssl/StatusStapling/CertStatusReqListV2ExtensionTests.java
(new)
 * test/sun/security/ssl/StatusStapling/OCSPStatusRequestTests.java (new)
 * test/sun/security/ssl/StatusStapling/StatusResponseManagerTests.java
(new)
 * test/sun/security/ssl/StatusStapling/TEST.properties (new)
 * test/sun/security/ssl/StatusStapling/TestCase.java (new)
 * test/sun/security/ssl/StatusStapling/TestUtils.java (new)

We see there how most of them are already covered by SSL-related test
categories. CertificateBuilder.java and SimpleOCSPServer.java are
addressed here, in Step 11.

Don't we want the following tests for Step 11?

 *
test/sun/security/provider/certpath/Extensions/OCSPNonceExtensionTests.java
(new)
 * test/sun/security/provider/certpath/ResponderId/ResponderIdTests.java
(new)

Thanks,
Martin.-



More information about the jdk8u-dev mailing list