[8u] RFR: 8226575: OperatingSystemMXBean should be made container aware

Severin Gehwolf sgehwolf at redhat.com
Mon Aug 24 12:24:01 UTC 2020


On Fri, 2020-08-21 at 19:22 +0100, Andrew Hughes wrote:
> On 10:58 Fri 21 Aug     , Severin Gehwolf wrote:
> > On Thu, 2020-08-20 at 21:44 +0100, Andrew Hughes wrote:
> > > Forgot to mention the HotSpot tests look ok other than:
> > > 
> > > +            if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
> > > +                DockerTestUtils.removeDockerImage(imageName);
> > > +            }
> > > 
> > > seems to be missing in a couple of the files. Why?
> > 
> > RETAIN_IMAGE_AFTER_TEST was introduced with JDK-8221710 which isn't in
> > OpenJDK 8u (yet). It's in my queue of docker test fixes. I can re-add
> > those missing hunks with the JDK-8221710 backport.
> > 
> > Thanks,
> > Severin
> > 
> 
> Would it not just make more sense to do JDK-8221710 first, retaining
> the order in 11u? It looks pretty simple.

No.

It would defer JDK-8226575 (high prio) for JDK-8221710 (test-only, low
priority). Also, I'm not sure JDK-8221710 has other dependencies. This
fix should go in now and then we can amend JDK-8221710 later once it
goes in. The earlier we get it in the more testing it can get before
8u272 goes live. It already had to wait for JDK-8203357. Note that the
initial RFR of this got sent over a month ago. This all adds up.

Thanks,
Severin



More information about the jdk8u-dev mailing list