[RFR] [8u] 8144539: Update PKCS11 tests to run with security manager

[Martin Balao]

Hi,

On Fri, Aug 21, 2020 at 10:43 PM Andrew Hughes <gnu.andrew at redhat.com> wrote:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8144539
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8144539/webrev.01/
>
>

A few comments:

 * There are a few tabs in PKCS11Test.java. Can we replace them with
white spaces? So we make sure that the code shows properly aligned
across IDEs.

 * I've seen several changes in a few files such as TestPRF.java,
TestMasterSecret.java, TestKeyMaterial.java, etc. TestKeyMaterial.java
was a bit easier for the naked eye. I take from your comment that you
didn't have any major conflict there beyond the '@modules' line,
right?

 * test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java and
test/sun/security/pkcs11/sslecc/JSSEServer.java changes will create a
conflict with the TLS 1.3 backport; affecting Steps 10, 11 and 15.

Otherwise, looks good to me.

With that said, I believe that this backport (which has low-priority)
should wait until the TLS 1.3 backport (high-priority) is merged.
Particularly because we are targeting the next release, and should be
able to merge this week -so it's not that we are blocking SSL-related
tests for a long time-. Otherwise, we would need to rebase and
generate + review Steps 10, 11 and 15 again. Note: 15 is still under
review, but I was expecting to have it ready in the next couple of
days. That's my view. I'll let other Reviewers decide here.

Thanks,
Martin.-