[8u] RFR: 8226575: OperatingSystemMXBean should be made container aware

[Andrew Hughes]

On 14:29 Mon 24 Aug     , Severin Gehwolf wrote:
> On Fri, 2020-08-21 at 19:37 +0100, Andrew Hughes wrote:
> > 
> > > > There is no Windows file in the 11u version. Why is it needed in 8u?
> > > > In both, OperatingSystemImpl.java seems to be under
> > > > src/jdk.management/unix/classes or src/solaris/classes/sun/management,
> > > > rather than share/classes.
> > > 
> > > Good point. There is a Windows specific OperatingSystemImpl.java with
> > > references to native methods. I missed that. Note to self: No need to
> > > change the native method impls as they've not changed
> > > in src/windows/classes/sun/management/OperatingSystemImpl.java either.
> > > Reverted in the updated webrev.
> > 
> > Thanks. It took me a while to spot it as well. At first, I thought Windows
> > was picking it up from one common shared Java file like the others, but
> > then I looked at the paths again and spotted the unix/solaris usage.
> > 
> > > Latest webrev here:
> > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8226575/jdk8/02/webrev/
> > > 
> > 
> > Thanks. JDK side looks good now.
> 
> Thanks again for the review!
> 
> > I'll wait for your response on
> > whether to do the other change first for the HotSpot side.
> 
> Please, lets not delay this any longer for a nice-to-have test cleanup.
>

Have you checked if the HotSpot test fix applies cleanly?

If it does, we may as well quickly approve it and get it in.

If not, there's no advantage to doing it first anyway, as it would
need a review with or without these additional changes.

My concern is turning a simple patch into one which needs review
because it is completed out of order.

Incidentally, this RFR may well have been posted a month ago, but it
wasn't actionable without the dependent patch first being reviewed and
approved.


snip...

> 
> > Out of interest, did the original pass on Windows?
> 
> I haven't tried, so I don't know. Probably not.

I did wonder, given the native methods no longer matched the
Java ones.

> 
> Thanks,
> Severin
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222