[RFR] [8u] 8144539: Update PKCS11 tests to run with security manager

[Andrew Hughes]

On 18:49 Tue 25 Aug     , Martin Balao wrote:
> On Tue, Aug 25, 2020 at 1:46 PM Andrew Hughes <gnu.andrew at redhat.com> wrote:
> > New webrev:
> >
> > https://cr.openjdk.java.net/~andrew/openjdk8/8144539/webrev.02/
> >
> 
> Ok, looks good to me.
>

Thanks. For the record, there were no test regressions. A common
set of 11 tests was failing both before and after the patch:

FAILED: sun/security/pkcs11/ec/ReadCertificates.java
FAILED: sun/security/pkcs11/ec/ReadPKCS12.java
FAILED: sun/security/pkcs11/ec/TestKeyFactory.java
FAILED: sun/security/pkcs11/fips/TestTLS12.java
FAILED: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh
FAILED: sun/security/pkcs11/rsa/TestCACerts.java
FAILED: sun/security/pkcs11/rsa/TestKeyPairGenerator.java
FAILED: sun/security/pkcs11/Secmod/GetPrivateKey.java
FAILED: sun/security/pkcs11/Secmod/JksSetPrivateKey.java
FAILED: sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java
FAILED: sun/security/pkcs11/tls/TestKeyMaterial.java

Some of these are due to missing curves in the system NSS.

> > It would be easier to see what files conflict with the TLS 1.3 work if
> > the work was publicly visible. I don't yet see any changes in:
> >
> > https://hg.openjdk.java.net/jdk8u/jdk8u-jsse-incubator/jdk/
> >
> > which is a little worrying for something you hope to have merged this
> > weekend.
> 
> Step 0 to 14 pushed today:
> http://hg.openjdk.java.net/jdk8u/jdk8u-jsse-incubator/jdk
> 
> Only Step missing: 15. I'm expecting to have it pushed later today -if
> no additional round-trips with the Developer are required- or
> tomorrow.
> 

This is good to hear. I'll try and have a look tomorrow.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222