[8u] TLSv1.3 RFR: 8251478: Backport TLSv1.3 regression tests to JDK8u

Alexey Bakhtin alexey at azul.com
Wed Aug 26 08:55:41 UTC 2020


Hi Martin,

Thank you for review.
All tests should pass after this step.
Webrev : http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8251478/webrev.v3/
Git diff: http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8251478/webrev.v3/jdk.git.diff

Regards
Alexey

> On 26 Aug 2020, at 01:22, Martin Balao <mbalao at redhat.com> wrote:
> 
>>> * test/sun/security/ssl/SSLSocketImpl/SSLSocketKeyLimit.java
>>> * 8u's equivalent of InputStream::readNBytes is IOUtils.readNBytes
>> OK. Fixed. But actually, it does not matter How many bytes
>> read from the stream  in this particular case.
> 
> In this file you are not throwing "Throwable" anymore (diff between
> Webrev.01 and 02). Was that intended?
> 
Sorry, did not revert experimental change. Fixed
> 
> Good!
> 
> In test/sun/security/ssl/internal/TestRun.sh, you commented the line
> that removes the JAR file. Looks to me that you want to revert that change.

Good catch. Thank you. jar should be removed. Fixed.

> 
> I'll now run all the SSL-related tests and expect them to pass. Is that
> expectation correct? Let me know if there is any known failure.
> 
> Thanks,
> Martin.-
> 



More information about the jdk8u-dev mailing list