[RFR] [8u] 8251120: HotSpot build assumes ENABLE_JFR is set to either true or false

[Mario Torre]

Looks good to me!

Cheers,
Mario


On Sat, Aug 22, 2020 at 4:41 AM Andrew Hughes <gnu.andrew at redhat.com> wrote:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8251120
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8251120/webrev.01/
>
> The HotSpot build on *nix systems currently assumes that ENABLE_JFR is
> set to either true or false. This is the case when the HotSpot build
> is invoked via the configure build system, but not otherwise, as
> nothing in the Makefiles actually sets it.
>
> A simple fix is to invert the tests for false, so only true is checked
> for, and false and undefined are assumed to be the same. Windows
> already only checks for true, so no changes are needed there.
>
> Ok for 8u?
>
> Thanks,
> --
> Andrew :)
>
> Senior Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
>
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222



--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898