[8u] RFR 8160768: Add capability to custom resolve host/domain names within the default JNDI LDAP provider

[Zhengyu Gu]

Hi Andrew,

Thanks for reviewing.

On 8/28/20 1:21 AM, Andrew Hughes wrote:
> On 10:24 Tue 25 Aug     , Zhengyu Gu wrote:
>> Okay, I restored @since 12.
>>
>> Updated: http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.04/
>>
>> I still don't have a strong opinion on this, but it is not a specific
>> problem for this backport.
>>
>> grep -r "@since" under jdk8u-dev/jdk, you see many versions > 8.
>>
>> If it needs to be addressed, we should address them at once and setup a
>> guideline for future backports.
>>
>> Could I get formal review now? I bet Michael is anxious to get this in.
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
> 
> In LdapDnsProviderService.java, I'd replace List.of() with Collections.emptyList()
> which gives the same unmodifiable empty list, rather than a new ArrayList<>() call.
> 

Good suggestion, updated: 
http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.05/

> Other changes (omission of public doc changes, package renaming, additional access
> requirement) look fine.
> 
> I am concerned that this is not in 11u yet. Is there some co-ordination between this
> backport and the 11u backport?
> 

I am aware of that Christoph is working on 11u backport. I don't know 
about whole story, but it seems that 11u is complicated than 8u, due to 
module.

Christoph, could you give us an update on 11u?

Thanks,

-Zhengyu

> Thanks,
>