[8u] RFR 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

[Andrew Hughes]

On 14:10 Fri 28 Aug     , Martin Balao wrote:
> Hi,
> 
> I'd like to propose Webrev.03:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8165996/8165996.jdk8u.jdk.webrev.03/
> 
> Differences with main line patch:
> 
>  * test/jdk/sun/security/pkcs11/PKCS11Test.java
>   * Hook does not apply because 8u does not have 8133318. In my opinion,
> 8133318 shouldn't be a dependency of 8165996 because it's about
> intermitent failures of some tests on Solaris 11.1 and earlier, and
> 8165996 is a fix to a bug related to the SQLite NSS DB format.

Yes, I made the same decision to leave the two Solaris fixes out
of the dependency trail [0] (JDK-8133318 & JDK-8170523) as I don't have
a means to test on Solaris easily, never mind this configuration.

> 
>  * test/jdk/sun/security/pkcs11/Secmod/TestNssDbSqlite.java
>   * '@modules' jtreg header do not apply to 8u

That's fine.

> 
> No test regressions observed in sun/security/pkcs11.
> 
> Thanks,
> Martin.-
> 
> 

Source changes look good.

I'm seeing a difference in the binary diff of the two .db files
and, when the patch is applied, they seem to apparently be from
a different SQLite version:

JDK 16:
$ file jdk/test/jdk/sun/security/pkcs11/Secmod/cert9.db
../../jdk/test/jdk/sun/security/pkcs11/Secmod/cert9.db: SQLite 3.x database, last written using SQLite version 3011000

JDK 8u with patch:
$ file test/sun/security/pkcs11/Secmod/cert9.db
test/sun/security/pkcs11/Secmod/cert9.db: SQLite 3.x database, last written using SQLite version 3014002

Can you please update the webrev with the versions used in 11u?

[0] https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3507

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222