[8u] RFR 8160768: Add capability to custom resolve host/domain names within the default JNDI LDAP provider

[Andrew Hughes]

On 08:34 Fri 28 Aug     , Zhengyu Gu wrote:
> Hi Andrew,
> 
> Thanks for reviewing.
> 
> On 8/28/20 1:21 AM, Andrew Hughes wrote:
> > On 10:24 Tue 25 Aug     , Zhengyu Gu wrote:
> > > Okay, I restored @since 12.
> > > 
> > > Updated: http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.04/
> > > 
> > > I still don't have a strong opinion on this, but it is not a specific
> > > problem for this backport.
> > > 
> > > grep -r "@since" under jdk8u-dev/jdk, you see many versions > 8.
> > > 
> > > If it needs to be addressed, we should address them at once and setup a
> > > guideline for future backports.
> > > 
> > > Could I get formal review now? I bet Michael is anxious to get this in.
> > > 
> > > Thanks,
> > > 
> > > -Zhengyu
> > > 
> > > 
> > 
> > In LdapDnsProviderService.java, I'd replace List.of() with Collections.emptyList()
> > which gives the same unmodifiable empty list, rather than a new ArrayList<>() call.
> > 
> 
> Good suggestion, updated:
> http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.05/
> 

Thanks. Please flag with jdk8u-fix-request.
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222