[8u] RFR 8228835: Memory leak in PKCS11 provider when using AES GCM

[Andrew Hughes]

On 15:12 Fri 28 Aug     , Martin Balao wrote:
> Hi,
> 
> I'd like to request a review of the 8u backport of 8228835 [1]:
> 
>  * Webrev.00
>   *
> http://cr.openjdk.java.net/~mbalao/webrevs/8228835/8228835.jdk8u.jdk.webrev.00/
> 
> Main line patch does not apply cleanly because:
> 
>  * src/share/native/sun/security/pkcs11/wrapper/p11_util.c
>   * 8074838 is not in 8u and the Hook #12 expects to see "*ckpLength =
> (CK_ULONG) strlen(pCharArray);" line around the modified line. In 8u,
> the line is "*ckpLength = strlen(pCharArray);". 8074838 (Resolve
> disabled warnings for libj2pkcs11) is not related to the bug that
> 8228835 fixes (Memory leak in PKCS11 provider when using AES GCM), so
> I've not considered it as a dependency.
> 
> Testing: I've observed no regressions in the sun/security/pkcs11 category.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8228835
> 

Looks fine to me. Please flag with jdk8u-fix-request.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222