[8u] RFR 8160768: Add capability to custom resolve host/domain names within the default JNDI LDAP provider

[Michael Osipov]

Am 2020-08-11 um 17:01 schrieb Zhengyu Gu:
> Hi,
>
> Webrevs are updated to reflect CSR[1].
>
> jdk: http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/jdk/webrev.02/
> langtools:
> http://cr.openjdk.java.net/~zgu/JDK-8160768-8u/langtools/webrev.01/

My tests/comments:
* @since still says 12. Is that correct?
* Should LdapDnsProvider and LdapDnsProviderResult document that they
have been moved in 12?

I have compiled my code with source/target 8 on Oracle JDK 11.0.8,
applied your patch on top of OpenJDK 1.8.0_265 on FreeBSD 12-STABLE. Ran
my code:
> $ /usr/local/openjdk8-ldap/bin/java  -Dorg.slf4j.simpleLogger.showDateTime=true -Djava.util.logging.config.file=logging.properties -jar ad-dns.jar
> 30 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Connecting to: ldap://ad001.siemens.net
> Aug 11, 2020 8:11:20 PM com.siemens.dynamowerk.ad.ActiveDirectoryDnsLocator locate
> FEIN: Looking up SRV RRs for '_ldap._tcp.S-DEBLN-03._sites.ad001.siemens.net'
> Aug 11, 2020 8:11:20 PM com.siemens.dynamowerk.ad.ActiveDirectoryDnsLocator locate
> FEINER: Found 4 SRV RRs for '_ldap._tcp.S-DEBLN-03._sites.ad001.siemens.net': [SRV RR: 0 100 389 dc1.ad001.siemens.net., SRV RR: 0 100 389 dc3.ad001.siemens.net., SRV RR: 0 100 389 dc2.ad001.siemens.net., SRV RR: 0 100 389 dc4.ad001.siemens.net.]
> Aug 11, 2020 8:11:20 PM com.siemens.dynamowerk.ad.ActiveDirectoryDnsLocator locate
> FEINER: Selected 4 servers for '_ldap._tcp.S-DEBLN-03._sites.ad001.siemens.net': [dc3.ad001.siemens.net:389, dc2.ad001.siemens.net:389, dc4.ad001.siemens.net:389, dc1.ad001.siemens.net:389]
> 268 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - dnsHostName: dc3.ad001.siemens.net
> 268 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Closing connection

As constrast stock OpenJDK 8u265:
> $ /usr/local/openjdk8/bin/java  -Dorg.slf4j.simpleLogger.showDateTime=true -Djava.util.logging.config.file=logging.properties -jar ad-dns.jar
> 17 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Connecting to: ldap://ad001.siemens.net
> 472 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - dnsHostName: dc6.ad001.siemens.net
> 472 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Closing connection
> 686 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Connecting to: ldap://ad001.siemens.net
> 1059 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - dnsHostName: dc6.ad001.siemens.net
> 1059 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Closing connection
> 1271 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Connecting to: ldap://ad001.siemens.net
> 1617 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - dnsHostName: dc6.ad001.siemens.net
> 1617 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Closing connection
> 1830 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Connecting to: ldap://ad001.siemens.net
> 2176 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - dnsHostName: dc6.ad001.siemens.net
> 2176 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Closing connection
> 2380 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Connecting to: ldap://ad001.siemens.net
> 2722 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - dnsHostName: dc6.ad001.siemens.net
> 2723 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Closing connection
> 2936 [main] INFO com.siemens.dynamowerk.ActiveDirectoryLdapTester - Connecting to: ldap://ad001.siemens.net

which relies on A records only and cannot be used to perform
GSS-API/Kerberos authentication afterwards.

You have my approval.

Thank you very much for pursuing this!

Michael