FW: RFR 8256642: [TEST_BUG] jdk/test/javax/sound/midi/MidiSystem/DefaultProperties.java failed

[Zhengyu Gu]

Looks good.

-Zhengyu

On 12/10/20 7:24 AM, hedongbo wrote:
> Ping?
> 
> From: hedongbo
> Sent: Friday, November 20, 2020 9:41 AM
> To: 'jdk8u-dev' <jdk8u-dev at openjdk.java.net>
> Subject: RFR 8256642: [TEST_BUG] jdk/test/javax/sound/midi/MidiSystem/DefaultProperties.java failed
> 
> Hi,
> 
> Please review this changes. Just adjusted the location of the sound.properties and removed some module tags.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8256642
> webrev: http://cr.openjdk.java.net/~dongbohe/8256642/webrev.00/
> 
> This code got introduced with JDK-8247840. In jdk8, the test case will look for files in “lib”, but in jkd9 it will look for files in “conf”
> jdk8: ./jdk/src/share/classes/com/sun/media/sound/JSSecurityManager.java:120
>              if (fname == null) {
>                  throw new Error("Can't find java.home ??");
>              }
>              File f = new File(fname, "lib");
>              f = new File(f, filename);
> jdk9: jdk/src/java.desktop/share/classes/com/sun/media/sound/JSSecurityManager.java:117
>              if (fname == null) {
>                  throw new Error("Can't find java.home ??");
>              }
>              File f = new File(fname, "conf");
>              f = new File(f, filename);
> 
> 
> Testing:  Worked correctly after patch.
> 
> Thanks,
> dongbohe
>