[8u] RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Hohensee, Paul hohensee at amazon.com
Thu Dec 10 16:28:22 UTC 2020


Lgtm. I've also reviewed the follow-on backport of 8228434.

Thanks,
Paul

-----Original Message-----
From: jdk8u-dev <jdk8u-dev-retn at openjdk.java.net> on behalf of Severin Gehwolf <sgehwolf at redhat.com>
Date: Wednesday, December 2, 2020 at 5:32 AM
To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: [8u] RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Hi!

Please review this test-only backport for OpenJDK 8u. I'd like to
backport this as it contains a test fix for TestCgroupMetrics
and TestSystemMetrics which occasionally can fail for equal values for
CPU usages (before/after). See changes in MetricsTester.java. On its
own it's useful too since it also makes the tests work with an
alternative container engine: podman.

Since this mostly changes test library code it's duplicated for jdk
tests in the jdk repo and hotspot tests in the hotspot repo. As such
the original JDK 11 patch doesn't apply cleanly. There is also no
jtreg-ext directory in 8u, so I've dropped the changes to VMProps.java.
It's not applicable. Some context changes in DockerTestUtils.java due
to JDK-8222888 and JDK-8222299, both not in 8u and no plan to backport
them at this point.

Bug: https://bugs.openjdk.java.net/browse/JDK-8227642
webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8227642/jdk8/

Testing: Container tests on Linux x86_64 using docker/podman.

Thoughts?

Thanks,
Severin




More information about the jdk8u-dev mailing list