[8u] RFR: 6949753: [TEST BUG]: java/awt/print/PageFormat/PDialogTest.java needs update by removing a infinite loop

Andrew Hughes gnu.andrew at redhat.com
Fri Dec 11 16:36:37 UTC 2020


On 16:19 Fri 11 Dec     , Jonathan Dowland wrote:
> Please review the following (trivial) patch for 8u. This is an Oracle
> parity backport patch that deletes a single test. The test was just
> brought in as part of a bundle in another backport.
> 
> Original bug: https://bugs.openjdk.java.net/browse/JDK-6949753
> Webrev: https://cr.openjdk.java.net/~jdowland/webrevs/JDK-6949753/webrev.00/
> 
> I've prepared a webrev because unshuffle_patch was unable to handle
> this. I tried both the version in the deprecated jdk/jdk HG repository
> and the git equivalent. (This is something for me to follow up on.)
> 
> 
> Best wishes
> 
> -- 
> ���� Jonathan Dowland <jdowland at redhat.com>
> Senior Software Engineer, OpenJDK, Red Hat
> 

I don't think this even needs review, as the file being removed is identical
in 8u to the one in 11u. I would always start with the version closest to 8u
that the patch is in, rather than trunk. There should rarely be a reason
that the patch is not in 11u first before coming to 8u.

Shuffling worked for me, though 'hg rm' will do the same job.

$ sh ../../jdk11/bin/unshuffle_patch.sh -to9 6949753.11u 6949753.9u
WARNING: no match found for +++ /dev/null
$ hg rm test/java/awt/print/PageFormat/PDialogTest.java
$ hg diff | diff -u 6949753.9u.jdk -
<no output>

$ cat 6949753.9u 6949753.9u.jdk > 6949753.8u
$ hg import 6949753.8u
applying 6949753.8u
$ hg export|diff -u 6949753.11u -
<only differences are node ID and path>

Please flag the bug and I'll approve and push.
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list