[8u] RFR: JDK-8257192: Integrate AArch64 JIT port into 8u

[Yangfei (Felix)]

Hi,

> -----Original Message-----
> From: Andrew Hughes [mailto:gnu.andrew at redhat.com]
> Sent: Wednesday, December 16, 2020 2:32 AM
> To: Yangfei (Felix) <felix.yang at huawei.com>
> Cc: jdk8u-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net
> Subject: Re: [8u] RFR: JDK-8257192: Integrate AArch64 JIT port into 8u
> 
> On 08:57 Sat 28 Nov     , Yangfei (Felix) wrote:
> > Hi,
> >
> > > -----Original Message-----
> > > From: jdk8u-dev [mailto:jdk8u-dev-retn at openjdk.java.net] On Behalf
> > > Of Andrew Hughes
> > > Sent: Friday, November 27, 2020 3:34 PM
> > > To: jdk8u-dev at openjdk.java.net
> > > Cc: aarch64-port-dev at openjdk.java.net
> > > Subject: Re: [8u] RFR: JDK-8257192: Integrate AArch64 JIT port into
> > > 8u
> > >
> > > On 07:21 Fri 27 Nov     , Andrew Hughes wrote:
> > > > Umbrella Bug: https://bugs.openjdk.java.net/browse/JDK-8257192
> > > > Webrevs:
> >
> > Thanks for bringing this to 8u upstream.
> >
> > I performed some testing on our platforms for the following patches based
> on the latest jdk8u-dev repo (jdk8u282-b03):
> >
> >
> https://cr.openjdk.java.net/~andrew/openjdk8/8257192/root/webrev.01/
> >
> https://cr.openjdk.java.net/~andrew/openjdk8/8257192/jdk/webrev.01/
> >
> >
> https://cr.openjdk.java.net/~andrew/openjdk8/8257192/hotspot/webrev.0
> 2
> > /
> >
> > 1. Run full jtreg test with release build on x86_64-linux-gnu, no regression
> witnessed.
> >      Passed jcstress test on x86_64-linux-gnu.
> >
> > 2. Run full jtreg test with release build on aarch64-linux-gnu, no regression
> witnessed. (Compared with jtreg test result of aarch64 release build from
> latest aarch64-port/jdk8u-shenandoah repo)
> >      Passed jcstress test on my 128-core aarch64 Kunpeng server.
> >
> > 3. Performed specjbb2015 test with release build on aarch64-linux-gnu.
> >      Performance numbers is reproducible as compared with aarch64 release
> build from latest aarch64-port/jdk8u-shenandoah repo.
> >
> > Hope that helps :-)
> >
> > Best regards,
> > Felix
> 
> It does.
> 
> Good to know it works for you :-)
> 
> I'll make another revision, based on Aleksey's latest comments, and we'll try
> and get this in.

I find aarch64 release & fastdebug fail to build with the three patches based on the latest jdk8u-dev repo.  I am using gcc version 7.5.0.

sh configure --prefix=/home/yangfei/jdk8u-release --with-jvm-variants=server --with-debug-level=release --enable-unlimited-crypto --with-native-debug-symbols=internal --with-boot-jdk=/home/yangfei/tools/jdk8u275-b01

Compile error message:
/home/yangfei/openjdk8u-dev/hotspot/src/cpu/aarch64/vm/aarch64.ad: In member function ‘virtual void cmpFastLockNode::emit(CodeBuffer&, PhaseRegAlloc*) const’:
/home/yangfei/openjdk8u-dev/hotspot/src/cpu/aarch64/vm/aarch64.ad:3354:85: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
     __ mov(tmp, (address) (~(os::vm_page_size()-1) | markOopDesc::lock_mask_in_place));
                                                                                     ^                                                                                     ^
I think we might need to add one extra patch here: http://hg.openjdk.java.net/jdk/jdk/rev/964186594f5f 
This patch is trivial and applies after path shuffling.  OK to build aarch64 release & fastdebug with this extra patch. 
Please take a look.

Thanks,
Felix