[8u] 8062808: Turn on the -Wreturn-type warning

[Andrew John Hughes]

On 06/02/2020 15:55, Hohensee, Paul wrote:
> Reviving this one.
> 
> Original issue: https://bugs.openjdk.java.net/browse/JDK-8062808
> Original patch: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ef7449e07592
> Webrev: http://cr.openjdk.java.net/~phh/8062808/webrev.8u.00/
> 
> Applies clean except for the lack of -Wformat=2 in 8u's gcc.make, and the lack of klass_at_ignore_error in 8u's constantPool.hpp.
> 
> Thanks,
> Paul
> 

Yeah, I've been holding off on this, because it affects downstream
out-of-tree-ports and I was hoping to get the AArch64 port in first.
However, I think that's now looking like something for 8u262.

I also appreciated, during the recent release processes, that neither 8u
& 11u build with -Werror for me as they stand upstream, so I would like
to see this resolved. I'll take a look at the patch on Monday.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew