RFR: [8u] 8225392: Comparison builds are failing due to cacerts file

Andrew John Hughes gnu.andrew at redhat.com
Thu Feb 13 07:27:43 UTC 2020


Bug: https://bugs.openjdk.java.net/browse/JDK-8225392
Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8225392/webrev.01/

This is the follow-up to 8193255 and requires similar changes to
GenerateCacerts.java in order for it to build during bootstrap with
OpenJDK 7.

Differences from 11u version:

1. In GenerateCacerts.java, we again use a loop over the directory
entries using Files.newDirectoryStream rather than a bunch of lambda
functions and the Streams API. Instead of creating an unsorted list and
then sorting it, we just add the entries directly to a TreeSet.

2. In GenerateCacerts.java and the test VerifyCACerts.java, we again
apply the change from JDK-8235142 of using Paths.get rather than
Path.of, which is only available in OpenJDK 11+.

3. The ListOrder.java test case @library and import lines are altered to
match the locations used in OpenJDK 8u for other tests in
test/sun/security/tools/keytool

Both VerifyCACerts.java & ListOrder.java fail before the patch, and pass
after.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew



More information about the jdk8u-dev mailing list