Marlin renderer patches for jdk8u integration

Laurent Bourgès bourges.laurent at gmail.com
Thu Feb 13 08:31:35 UTC 2020


Dear Paul,
Thank you for being promptly back !


Le jeu. 13 févr. 2020 à 01:40, Hohensee, Paul <hohensee at amazon.com> a
écrit :

> Rather than go through a pile of separate reviews, here’s a review for all
> the ones for which Andrew asked a review.  I used the patches for the first
> 12 issues on the list at
> http://cr.openjdk.java.net/~lbourges/marlin-jdk8/marlin-jdk8.0/.
>
I suppose it is in fact:
http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8.03_to_12/

>
>
> 8143849: has been pushed to 8u.
>
>
>
> 8145055: approved by Andrew.
>
>
>
> 8144630: lgtm.
>
>
>
> 8144446: approved by Andrew.
>
> 8144445: approved by Andrew.
>
>
>
> 8144526: lgtm.
>
>
>
> 8144654: approved by Andrew.
>
> 8144718: approved by Andrew.
>
>
>
> 8149338: lgtm. The patch looks clean to me.
>
>
>
> 8148886: lgtm. The cleanerObj definition is in the diff context lines, not
> in the actual diffs, so the patch applies cleanly to RendererContext.java,
> net of context. 8147443 uses the Cleaner and associated classes that
> replaced finalizers. They haven’t been backported to 8u.
>
>
>
> 8144938: lgtm. I don’t see any differences in the diffs. :)
>
>
>
> 8159093: lgtm. I don’t see any context differences. RenderContext.java
> isn’t in the patch.
>
I will start one Official RFR thread per bug needing a review according to
Andrew: 6 in total.

Please approve these RFR directly to follow the backport process.

Thank you in advance,
Laurent


More information about the jdk8u-dev mailing list