Re: [8u] [JFR] RFR: 8236160: Missing ThreadCrashProtection for JFR in signal handler

[Denghui Dong]

Yes, it's necessary to create a repeatable test for ThreadCrashProtection, I will try it later.

And could I push it to jdk8u-jfr-incubator now?

Thanks
Denghui Dong
------------------------------------------------------------------
From:Andrew Dinn <adinn at redhat.com>
Send Time:2020年2月13日(星期四) 18:46
To:董登辉(卓昂) <denghui.ddh at alibaba-inc.com>; jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject:Re: [8u] [JFR] RFR: 8236160: Missing ThreadCrashProtection for JFR in signal handler

Hi Denghui,

On 13/02/2020 06:06, Denghui Dong wrote:
> Thanks for the review.
> Because there is no test case to verify the correctness, I added some
> additional code snippets (not included in the patch), 
> . . .
> If I use the JDK without this patch to run
> "java -XX:StartFlightRecording version", the process will be aborted,
>  . . .
> And everything is fine when I use the JDK with this patch.
> Do you think it's ok?
Well, that at least proves that it the new crash protection code is working.

It would be better if there were a repeatable test for this (in order to
ensure that it stays working). However, that also applies to the
upstream code and I could not find any such test upstream. I can see why
it might be hard to create such a test. I guess this will have to do.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill