[JFR: jdk8u-jfr-incubator] RFR: JDK-8238589: Necessary code cleanup in JFR for JDK8u

[Mario Torre]

Can I push the fix, then?

Cheers,
Mario

On Wed, Feb 12, 2020 at 5:02 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 2/12/20 4:56 PM, Andrey Petushkov wrote:
> >> I don't want these two things to interact. So this is why you need the assert before the branch to
> >> verify that we are testing against the sane value:
> >>
> >>  #if INCLUDE_JFR
> >>      assert(jfr_event_handler_proxy != NULL, "invariant");
> >>      if (k.is_null() && (class_name == jfr_event_handler_proxy)) {
> >>  ...
> > Just please be aware that it's legit to have jfr_event_handler_proxy ==
> > NULL for a while during VM startup, including
> > while loading a few bootstrap classes. So if you put this assert
> > unconditionally you'll crash with it unconditionally :)
> > (see systemDictionary.cpp lines 1910 and 1912)
>
> Oh wow, okay. Nevermind then!
>
> --
> Thanks,
> -Aleksey
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898