RFC: backport of JDK-8215756: Memory leaks in the AWT on macOS

[Andrew Hughes]

On 26/08/2019 14:48, Simon Tooke wrote:
> 
> On 8/2/2019 4:42 AM, Aleksey Shipilev wrote:
>> On 7/31/19 7:12 PM, Simon Tooke wrote:
>>> http://cr.openjdk.java.net/~stooke/webrevs/jdk8215756-jdk8u.01/
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8215756
>>> Original patch: http://hg.openjdk.java.net/jdk/client/rev/64e7a73195c1
>> Looks okay. It seems webrev was generated in default mode that omits whitespace diffs. Try with -b.
> 
> I've redone the webrev with -b, but it didn't make much difference. 
> 
> Also, I updated the copyright one one of the files.
> 
> new webrev:
> http://cr.openjdk.java.net/~stooke/webrevs/jdk-8215756-jdk8u/02/jdk.02/
> 
> 
> Thanks,
> 
> -Simon
> 
> 

Why are we chnaging the copyright dates from 2018 in the original patch
to 2019? That would just seem to create trouble for later backports.

I agree with Aleksey's comments in general about keeping as close to the
original change as possible. Backports are not the place to be creative.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222