RFC: backport of JDK-8215756: Memory leaks in the AWT on macOS

[Andrew Hughes]

On 18/02/2020 10:44, Mario Torre wrote:
> On Tue, Feb 18, 2020 at 11:40 AM Andrew Hughes <gnu.andrew at redhat.com> wrote:
>>> Also, I updated the copyright one one of the files.
>>>
>>> new webrev:
>>> http://cr.openjdk.java.net/~stooke/webrevs/jdk-8215756-jdk8u/02/jdk.02/
>>>
>>>
>>> Thanks,
>>>
>>> -Simon
>>>
>>>
>>
>> Why are we chnaging the copyright dates from 2018 in the original patch
>> to 2019? That would just seem to create trouble for later backports.
>>
>> I agree with Aleksey's comments in general about keeping as close to the
>> original change as possible. Backports are not the place to be creative.
> 
> I think this stems from the practice of updating the copyright year in
> files that are touched by changes, but I agree with you we shouldn't
> do it in backports unless the original patch also has the change.
> 
> Cheers,
> Mario
> 

Yes, I can see the reasoning, but I've also done enough backports that
break just because of differing copyright headers, that I'd rather
minimise the chance of that if possible :)
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222