Request for Approval: Backport of 8047212 : runtime/ParallelClassLoading/bootstrap/random/inner-complex assert(ObjectSynchronizer::verify_objmon_isinpool(inf)) failed: monitor is invalid

[Yangfei (Felix)]

> -----Original Message-----
> From: Andrew Hughes [mailto:gnu.andrew at redhat.com]
> Sent: Wednesday, February 19, 2020 12:15 PM
> To: Yangfei (Felix) <felix.yang at huawei.com>; jdk8u-dev at openjdk.java.net
> Subject: Re: Request for Approval: Backport of 8047212 :
> runtime/ParallelClassLoading/bootstrap/random/inner-complex
> assert(ObjectSynchronizer::verify_objmon_isinpool(inf)) failed: monitor is
> invalid
> 
> 
> 
> On 20/08/2019 03:43, Yangfei (Felix) wrote:
> > Hi,
> >
> >
> >
> > May I got review for the backport of 8146792 to 8u master repo please?
> >
> >
> >
> > Webrev:
> > http://cr.openjdk.java.net/~fyang/8047212-8u-backport/webrev.00/
> >
> >
> >
> >        Bug: https://bugs.openjdk.java.net/browse/JDK-8047212
> >
> >        JDK9 Changeset:
> > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/a0c7a69277da
> >
> >
> 
> PaddedEnd is introduced by JDK-8049737, which is part of JEP-143, so I agree it
> makes sense to workaround this change rather than backport it.
> The code is essentially the same, minus the wrapping of the ObjectMonitor in
> PaddedEnd.
> 
> Some minor issues:
> 
> * Empty line lost between:
> 
> +        oop obj = (oop)mid->object();
> 
> and
> 
> +        if (obj == NULL) {
> 
> * Empty line lost between:
> 
> +        deflated = deflate_monitor(mid, obj, &FreeHead, &FreeTail);
> 
> and
> 
> +        if (deflated) {
> 
> Both are in synchronizer.cpp and cause the diffs to not line up when compared
> with the original 9u changeset.

Thanks for the careful review.  I have updated accordingly.  
New webrev: http://cr.openjdk.java.net/~fyang/8047212-8u-backport/webrev.01/  
Please help push it if it's OK to go.  

Best regards,
Felix