8144630: Use PrivilegedAction to create Thread in Marlin RendererStats

[Hohensee, Paul]

Also lgtm.

Paul

From: Laurent Bourgès <bourges.laurent at gmail.com>
Date: Tuesday, February 18, 2020 at 9:04 AM
To: Andrew Hughes <gnu.andrew at redhat.com>
Cc: jdk8u-dev <jdk8u-dev at openjdk.java.net>, "Hohensee, Paul" <hohensee at amazon.com>
Subject: Re: RFR: 8144630: Use PrivilegedAction to create Thread in Marlin RendererStats

Hi Andrew,

I fixed the patch (in-place) to only fix import, no indentation change:
http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8.03/m03.8144630.patch

Here is the updated webrev:
http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8.03/m03.8144630-webrev.1/

Thanks,
Laurent

Le lun. 17 févr. 2020 à 07:51, Andrew John Hughes <gnu.andrew at redhat.com<mailto:gnu.andrew at redhat.com>> a écrit :


On 13/02/2020 13:25, Laurent Bourgès wrote:
> Please review this 3rd patch to backport the Marlin renderer from jdk9.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8144630
> patch:
> http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8.03/m03.8144630.patch
> webrev:
> http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8.03/m03.8144630-webrev/
> unshuffled patch:
> http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8.03/unshuffled/8-m03.8144630.patch
>
> Changes in RendererStats:
> * Fixed import:
> -+import sun.awt.util.ThreadGroupUtils;
> ++import sun.misc.ThreadGroupUtils;
> * Fixed indentation / chunks
> <http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8.03/>
>
> Best regards,
> Laurent
>

Why was it necessary to fix "indentation / chunks"?

I tried applying the 8144630 changeset from OpenJDK 9 and it applied as
is, so the only necessary change would seem to be the import.

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net<http://keys.gnupg.net>)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew


--
--
Laurent Bourgès