Marlin renderer patches for jdk8u integration

[Andrew Hughes]

On 19/02/2020 08:13, Laurent Bourgès wrote:
> Hi Andrew,
> 
> As we started this effort to backport Marlin in openjdk 8u 252, I want
> this task to be finished as soon as possible. 
> I know jd8u roadmap has a short window: RDP at 02.26 in 1 week. As
> Marlin renderer is disabled by default in 8u, it does not hurt. This
> backport can go on and will be ready in later 8u release.
> 
> Currently m01 & m02 patches are pushed, m03 is in RFR.
> 
> How can we go faster ? 
> 1. Maybe I can start several RFR in parallel, but how can I tell
> webrev.ksh to make incremental web revs without committing every patch
> in my local mercurial repository.
> 
> HG clone is very slow, so I can not do for every patch. 
> I tried using a local branch (but jcheck complained, so I disabled it)
> but a branch can not be deleted in mercurial. I can use backups (remote
> tip) to manually revert / update...
> 
> How do you usually make incremental web revs ?
> 

Please don't. If it's complicated to create webrevs, because they are
built on top of an intermediate state, that also suggests it's going to
make it complicated and confusing to review.

> 2. RFR mails + JBS fix requests are great but this workflow imposes high
> latency... Maybe we could group them and follow a schedule: every
> wednesday RFR / fix requests must be ready / processed... patches ready
> be pushed.

I'm not sure how this would be different from what we're already doing.
Can you elaborate?

> 
> If possible, could we have a phone call ?
> 

Sure, if that helps.

> Thanks,
> Laurent

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222