[JFR: jdk8u-jfr-incubator] RFR: JDK-8239479: minimal1 and zero builds are failing

[Andrew Hughes]

On 19/02/2020 17:35, Andrey Petushkov wrote:
> Hi All,
> 
> could you please review small patch which aims to disable build of JFR
> when user
> requested minimal1 or zero build of VM. JFR code is incompatible with
> minimal and zero VMs
> and the proposed behavior is demonstrated by jdk11 implementation.
> However because the jdk11
> build system is completely different in this place I got to invent
> jdk8-specific implementation.
> 
> webrev: https://cr.openjdk.java.net/~apetushkov/8239479/
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8239479
> 
> Thanks,
> Andrey
> 

The change itself looks good.

However, I'm confused as this seems to be based on top of an
--enable-jfr option which is enabled by default. I thought we had
decided not to do this just yet?

So the default value of enable_jfr here should be no, not auto just yet.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222