[8u] RFR 8231430: C2: Memory stomp in max_array_length() for T_ILLEGAL type

Aleksey Shipilev shade at redhat.com
Thu Feb 20 09:01:12 UTC 2020


On 2/20/20 4:47 AM, Andrew Hughes wrote:
> Given I don't see us backporting ConstantDynamic, could we not include
> that small change to globalDefinitions.hpp in this fix, rather than
> transposing its body into the if block in src/share/vm/opto/type.cpp?

Well, other backports we did substituted is_reference_type call with the explicit body. The rest of
HS code uses the same pattern (before JDK-8230505), so it is not like we are doing something out of
whack. The only valid reason I would see to import is_reference_type here is in case we would
backport JDK-8230505 at some point later, which seems very unlikely.

We can still do that, if you insist:
  https://cr.openjdk.java.net/~shade/8231430/webrev.8u.02/

-- 
Thanks,
-Aleksey



More information about the jdk8u-dev mailing list