[8u] RFR 8167409: Invalid value passed to critical JNI function

[Andrew Hughes]

On 20/02/2020 13:24, Yangfei (Felix) wrote:
>> -----Original Message-----
>> From: Andrew Hughes [mailto:gnu.andrew at redhat.com]
>> Sent: Thursday, February 20, 2020 11:00 AM
>> To: Yangfei (Felix) <felix.yang at huawei.com>; jdk8u-dev at openjdk.java.net
>> Subject: Re: [8u] RFR 8167409: Invalid value passed to critical JNI function
>>
>>
>>
>>>> Generally happy with the patch, but would omit the copyright header
>>>> changes, as they are just going to create problems for future backports.
>>>
>>> Do you mean the Copyright years update in these files?
>>>
>>
>> Yes, the addition of 2019 in
>> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp &
>> test/compiler/runtime/criticalnatives/argumentcorruption/CheckLongArgs.jav
>> a
>>
>> This is appropriate for a new patch, but for a backport, it will create future
>> friction.
> 
> Thanks for explaining this. 
> 
>>>> Also, the /runtime should probably be dropped from the test path as
>>>> other tests in 8u aren't under the runtime subdirectory.
>>>
>>> Good suggestion.  I can propose a new webrev if you want.
>>>
>> Please.
> 
> New webrev: http://cr.openjdk.java.net/~fyang/8167409-8u-backport/webrev.01/ 
> 
> Thanks,
> Felix
> 

Thanks. This looks good now.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222