JDK-8022263: use same Clang warnings on BSD as on Linux - Any *BSD testers?

[Fedor]

Hi Andrew!

 > Did the build succeed on Mac OS? I expect that's the only *BSD platform
 > that's seen much maintenance for 8u and I'm not sure who builds it
 > regularly now either :(
Mac OS build succeed with the next toolchain:

 > On 20/02/2020 15:41, Fedor wrote:
 >> macOS build also has been checked:
 >>
 >> xcodebuild -version
 >> Xcode 4.6.2
 >> Build version 4H1003
 >>
 >> Toolchain: gcc (GNU Compiler Collection)
 >> C Compiler:  Version 4.2.1 (at /usr/bin/gcc)
 >> C++ Compiler:  Version 4.2.1 (at /usr/bin/g++)

Azul builds 8u macOS binaries regularly. 
(https://www.azul.com/downloads/zulu-community/?&version=java-8-lts&os=&os=macos&architecture=x86-64-bit&package=jdk)

 > I'd be interested in the failures for NetBSD. Maybe there is an existing
 > fix for them we can backport or a new patch we can apply.
Unfortunately there is not existing patch at the time being. (at least I 
failed to find one)
I'm trying to fix NetBSD related bugs right now, but work is in the 
middle: several of bugs are in progress, and some clean-up is required.
If there is interest in this activity I can share my results a little 
bit later. (Do I need to file bug in JBS for that, or just post webrevs?)

Thanks,
Fedor



On 27.02.2020 8:27, Andrew Hughes wrote:
> 
> 
> On 20/02/2020 15:41, Fedor wrote:
>> macOS build also has been checked:
>>
>> xcodebuild -version
>> Xcode 4.6.2
>> Build version 4H1003
>>
>> Toolchain: gcc (GNU Compiler Collection)
>> C Compiler:  Version 4.2.1 (at /usr/bin/gcc)
>> C++ Compiler:  Version 4.2.1 (at /usr/bin/g++)
>>
>>
>> On 20.02.2020 17:48, Fedor wrote:
>>> Hello Andrew,
>>>
>>> As far as I can see OpenJDK 8u build is broken for *BSD targets at the
>>> time being.
>>> At least I succeed to build JDK for NetBSD 6 only after a bunch of
>>> changes in ./make ./hotspot/make and jdk/make.
>>> Used compiler is x86_64--netbsd-gcc (NetBSD nb2 20111202) 4.5.3
>>>
>>> I've checked the modifications and can say that mentioned JDK-8022263
>>> changeset
>>> (http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/d16be2b85802)
>>> doesn't bring new compilation problems for *BSD using GCC.
>>>
>>> Thanks,
>>> Fedor
>>>
>>>
>>> On 20.02.2020 8:36, Andrew Hughes wrote:
>>>> I'm looking at https://bugs.openjdk.java.net/browse/JDK-8022263, which
>>>> is a clean backport and a pre-requisite for some later changes.
>>>>
>>>> This is a fairly simple patch, basically synchronising the warning logic
>>>> with the GNU/Linux platform. The patch builds fine with GCC 7 on
>>>> GNU/Linux, but it would be good if someone could check these additional
>>>> flags don't break the build on *BSD.
>>>>
>>>> Generally, it'd also be good to know who is testing 8u on which
>>>> platforms for fixes such as this.
>>>>
>>>> Thanks,
>>>>
>>
> 
> Hi Fedor,
> 
> Thanks for doing this testing. It's much appreciated.
> 
> Did the build succeed on Mac OS? I expect that's the only *BSD platform
> that's seen much maintenance for 8u and I'm not sure who builds it
> regularly now either :(
> 
> I'd be interested in the failures for NetBSD. Maybe there is an existing
> fix for them we can backport or a new patch we can apply.
> 
> Thanks,
>