[8u] RFR: 8186576: [2/2] KerberosTicket does not properly handle renewable tickets at the end of their lifetime

[Verghese, Clive]

Thank you Volker for reviewing the change.

Regards,
Clive Verghese

On 1/7/20, 11:31 AM, "Volker Simonis" <volker.simonis at gmail.com> wrote:

    Hi,
    
    I've also looked at this backport on top of JDK-8044500 (i.e. after
    applying the backport for 8044500).
    
    The change looks good to me except the fact that it again contains
    tabs at places where the original change had spaces. I've therefore
    created a new webrev which fixes this:
    
    http://cr.openjdk.java.net/~simonis/webrevs/2020/8186576.8u.01/
    
    It also removes on line which updated the copyright information in
    KDC.java which isn't required because the copyright was already newer
    in that file after 8044500.
    
    I did a clean build with both backports applied and ran all the
    Kerberos tests under sun/security/krb5 . They all succeeded except
    "sun/security/krb5/auto/ReplayCacheTestProc.java", but that one also
    failed without these backports so I assume it must be another problem.
    
    I'm fine with this downport (and JDK-8044500 as well, as detailed in
    its own mail thread [1]) and you can consider it reviewed (if nothing
    exceptional happens, I should even be an "official" JDK 8 Updates
    Reviewer by the end of today :)
    
    Best regards,
    Volker
    
    [1] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-January/010904.html
    
    On Mon, Dec 2, 2019 at 11:06 PM Hohensee, Paul <hohensee at amazon.com> wrote:
    >
    > Ping for another review pls.
    >
    > Thanks,
    > Paul
    >
    > On 11/18/19, 3:48 PM, "jdk8u-dev on behalf of Hohensee, Paul" <jdk8u-dev-bounces at openjdk.java.net on behalf of hohensee at amazon.com> wrote:
    >
    >     Lgtm. I looked at [1/2] JDK-8044500 first, and same request applies: would another reviewer also take a look please?
    >
    >     Thanks,
    >
    >     Paul
    >
    >     On 11/8/19, 11:39 AM, "jdk8u-dev on behalf of Verghese, Clive" <jdk8u-dev-bounces at openjdk.java.net on behalf of verghese at amazon.com> wrote:
    >
    >         Hi,
    >
    >         Requesting review for backport of JDK-8186576.
    >
    >         JDK-8186576
    >         JBS Issues : https://bugs.openjdk.java.net/browse/JDK-8186576
    >         Original Change : http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/fa7582840977
    >         Webrev : http://cr.openjdk.java.net/~alvdavi/webrevs/8186576/webrev.8u.00/
    >
    >
    >         The backport did not apply cleanly, It required changes from JDK-804450. The test case written for JDK-8186576, specifically NullRenewUntil, was requesting renewable tickets, support for which was added in JDK-8044500.
    >         Additionally parts of JDK-8044500 had already been backported.
    >
    >         We could
    >
    >           1.  Add the required functions and update the tests. Or
    >           2.  Backport JDK-8044500
    >
    >         I have backported both JDK-8044500 and JDK-8186576.
    >
    >         Other than the usual changes to filenames and copyrights, The patches also needed minor modifications mentioned below.
    >
    >         JDK-8186576
    >
    >           *   Variable name change in KDC.java
    >           *   Missing ‘{‘ in the if blocks in KerberosTicket.java
    >
    >
    >         Regards,
    >         Clive Verghese
    >
    >
    >
    >