RFR (S) 8234288: Turkey Time Zone returns incorrect time zone name

[Hohensee, Paul]

That's the correct test. This is with the patch, right? I pushed it before I saw this, so it'd be great if you could do a build and run it.

Perhaps it fails on my host due to a configuration issue. Here's the output both before and after the patch.

Mismatch in FormatData/zh_HK/MonthNames/0:
  file = "\\u4e00\\u6708"
   jvm = "January"
Mismatch in FormatData/zh_HK/MonthNames/1:
  file = "\\u4e8c\\u6708"
   jvm = "February"
Mismatch in FormatData/zh_HK/MonthNames/2:
  file = "\\u4e09\\u6708"
   jvm = "March"
Mismatch in FormatData/zh_HK/MonthNames/3:
  file = "\\u56db\\u6708"
   jvm = "April"
Mismatch in FormatData/zh_HK/DayNames/0:
  file = "\\u661f\\u671f\\u65e5"
   jvm = "Sunday"
Mismatch in FormatData/zh_HK/DayNames/1:
  file = "\\u661f\\u671f\\u4e00"
   jvm = "Monday"
Mismatch in FormatData/zh_HK/DayNames/2:
  file = "\\u661f\\u671f\\u4e8c"
   jvm = "Tuesday"
Test failed.  7 errors.

Thanks,
Paul

On 1/14/20, 9:37 PM, "Andrew John Hughes" <gnu.andrew at redhat.com> wrote:

    
    
    On 15/01/2020 05:22, Andrew John Hughes wrote:
    > 
    > 
    > On 14/01/2020 23:46, Hohensee, Paul wrote:
    >> Please review this backport to jdk8u.
    >>
    >> JBS issue: https://bugs.openjdk.java.net/browse/JDK-8234288
    >> Webrev: http://cr.openjdk.java.net/~phh/8234288/webrev.8u.00/
    >> Original patch: https://hg.openjdk.java.net/jdk/jdk/rev/e7f7be79ba52
    >> Original email thread:
    >> https://mail.openjdk.java.net/pipermail/i18n-dev/2019-November/002983.html
    >> https://mail.openjdk.java.net/pipermail/i18n-dev/2019-December/003005.html
    >>
    >> The patch applies cleanly except for the JBS issue list in LocaleDataTest.java. The latter fails on an unrelated issue (or issues) the same way it did before the patch.
    >>
    >> Thanks,
    >> Paul
    >>
    > 
    > Patch looks good to me.
    > 
    > It's also worth keeping an eye out for any further changes which add
    > localised versions of TRT to TimeZoneNames_*.java
    > 
    > And yes, the locale tests remain something we need to look at :(
    > 
    > Thanks,
    > 
    
    Am I looking at the right test? :/
    
    $ run_jtreg.sh /mnt/builder/8u/images/j2sdk-image
    jdk/test/sun/text/resources/LocaleDataTest.java
    Java: /mnt/builder/8u/images/j2sdk-image
    Test Path: jdk/test/sun/text/resources/LocaleDataTest.java
    Passed: sun/text/resources/LocaleDataTest.java
    Test results: passed: 1
    
    -- 
    Andrew :)
    
    Senior Free Java Software Engineer
    Red Hat, Inc. (http://www.redhat.com)
    
    PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
    Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
    https://keybase.io/gnu_andrew