[8u] RFR: 8237523: 8u backport of JDK-8216354 didn't include generated-configure.sh changes

Aleksey Shipilev shade at redhat.com
Mon Jan 20 09:44:08 UTC 2020


On 1/20/20 10:40 AM, Severin Gehwolf wrote:
> Could I get a review of this 8u-only change, please? JDK-8216354 8u
> backport is missing generated-configure.sh changes. This fixes it:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8237523
> 
> $ hg diff
> diff --git a/common/autoconf/generated-configure.sh b/common/autoconf/generated-configure.sh
> --- a/common/autoconf/generated-configure.sh
> +++ b/common/autoconf/generated-configure.sh
> @@ -4376,7 +4376,7 @@
>  #CUSTOM_AUTOCONF_INCLUDE
>  
>  # Do not change or remove the following line, it is needed for consistency checks:
> -DATE_WHEN_GENERATED=1565358475
> +DATE_WHEN_GENERATED=1579512479
>  
>  ###############################################################################
>  #
> @@ -51600,7 +51600,7 @@
>      { $as_echo "$as_me:${as_lineno-$LINENO}: checking for UCRT DLL dir" >&5
>  $as_echo_n "checking for UCRT DLL dir... " >&6; }
>      if test "x$with_ucrt_dll_dir" != x; then
> -      if test -z "$(ls -d "$with_ucrt_dll_dir/*.dll" 2> /dev/null)"; then
> +      if test -z "$(ls -d "$with_ucrt_dll_dir/"*.dll 2> /dev/null)"; then
>          { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
>  $as_echo "no" >&6; }
>          as_fn_error $? "Could not find any dlls in $with_ucrt_dll_dir" "$LINENO" 5
> 
> I've got a pending patch which changes generated-configure.sh and I
> didn't want to include this unrelated change.

Looks fine to me; assuming this one is basically the autogenerated patch.

-- 
Thanks,
-Aleksey



More information about the jdk8u-dev mailing list