RFR: 8233995: java.vm.vendor (and potentially other properties/fields) not correctly set in Windows/Hotspot build of OpenJDK8

[Langer, Christoph]

Thanks, Andrew.

I just pushed it.

> -----Original Message-----
> From: Andrew John Hughes <gnu.andrew at redhat.com>
> Sent: Freitag, 24. Januar 2020 18:46
> To: Langer, Christoph <christoph.langer at sap.com>; jdk8u-
> dev at openjdk.java.net
> Subject: Re: RFR: 8233995: java.vm.vendor (and potentially other
> properties/fields) not correctly set in Windows/Hotspot build of OpenJDK8
> 
> 
> 
> On 28/12/2019 17:05, Langer, Christoph wrote:
> > Hi Andrew,
> >
> > I've finally gotten back to this and spent some more cycles.
> >
> > Here is a new webrev:
> http://cr.openjdk.java.net/~clanger/webrevs/8233995.8u.1/
> >
> > I'm now passing COMPANY_NAME, VENDOR_URL, VENDOR_URL_BUG,
> VENDOR_URL_VM_BUG and VERSION_CFLAGS via MAKE_ARGS in
> make/windows/makefiles/defs.make. I needed to add some logic for
> converting VERSION_CFLAGS into a value that can be passed as argument to
> the nmake call and would then also be consumable by the VS C++ compiler.
> The elegant thing of doing it so is that I don't need to duplicate the logic for
> creating VERSION_CFLAGS from spec.gmk in
> make/windows/makefiles/vm.make.
> >
> > I also removed the common amendment of CXX_FLAGS with VENDOR
> defines in make/windows/makefiles/vm.make and I would pass
> VERSION_CFLAGS only to the compilation of vm_version.cpp and
> arguments.cpp as it is done on the other platforms. I furthermore fixed the
> value of VENDOR in generated file local.make (done in
> make/windows/build.make) and I also corrected the value of HS_COMPANY
> in the RC flags for creating jvm.dll in
> make/windows/makefiles/compile.make.
> >
> > Cheers
> > Christoph
> >
> 
> Thanks for digging into this and fixing up my blind attempt in 8189761.
> 
> The revised patch looks good to me.
> 
> Thanks,
> --
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> https://keybase.io/gnu_andrew